Completed implementation #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented HighestSequenceNrEntry to keep track of the highest sequence number separate from the journal entries themselves Updated replay query to consider the highest sequence number entry
…ion of the two tests that will not pass when the entire spec is run but will pass if run individually
|
@kaleho looks great - I'll review it as soon as I can. |
|
Looks like we have a couple of merge conflicts here since I merged in your other PR @kaleho - I'll try to get these fixed myself today, but if you can beat me to the punch I'd appreciate it. Once those are in I'll release this to NuGet. |
|
@Aaronontheweb I will try and take care of it tonight. |
|
I kdiff'ed the files and re-ran the tests. I think it is good now. |
|
@kaleho thanks, I'll review it. |
|
LGTM - going to pull down the source and do some more tweaks before we do a release. Great work @kaleho |
IgorFedchenko
pushed a commit
to IgorFedchenko/Akka.Persistence.Azure
that referenced
this pull request
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Aaronontheweb This is the completed branch I mentioned. I am attaching a capture of the tests as well as the output of the failed tests. As I mentioned the two tests fail when the entire group is run but if I run individually they pass.
Hope that makes sense.
ReadJournal_CurrentEventsByPersistenceId_should_return_empty_stream_for_cleaned_journal_from_0_to_MaxLong.txt
ReadJournal_CurrentEventsByPersistenceId_should_return_remaining_values_after_partial_journal_cleanup.txt